<html>
<head><meta charset="utf-8"><title>retrospective on backport nomination for PR #73613 · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html">retrospective on backport nomination for PR #73613</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="205493835"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205493835" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205493835">(Jul 30 2020 at 15:32)</a>:</h4>
<p>hey <span class="user-mention" data-user-id="116266">@Santiago Pastorino</span>, <span class="user-mention" data-user-id="116122">@simulacrum</span>, and <span class="user-mention" data-user-id="125250">@Wesley Wiser</span>  , lets talk here about what we should change in our processes to avoid a repeat occurrence of the issues that arose here.</p>



<a name="205493876"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205493876" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205493876">(Jul 30 2020 at 15:33)</a>:</h4>
<p>hm this one seemed to be fine, I was talking about the other stable nom</p>



<a name="205493894"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205493894" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205493894">(Jul 30 2020 at 15:33)</a>:</h4>
<p>and discussed a bit here <a href="#narrow/stream/131828-t-compiler/topic/putting.20stable-noms.20on.20release.20radar">https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/putting.20stable-noms.20on.20release.20radar</a></p>



<a name="205494026"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205494026" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205494026">(Jul 30 2020 at 15:34)</a>:</h4>
<p>oh did I get confused? let me see</p>



<a name="205494259"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205494259" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205494259">(Jul 30 2020 at 15:36)</a>:</h4>
<p>If I understand correctly, PR <a href="https://github.com/rust-lang/rust/issues/73613">#73613</a> got into the current beta via the natural train process</p>



<a name="205494296"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205494296" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205494296">(Jul 30 2020 at 15:36)</a>:</h4>
<p>but we did not realize that it wasn't in the previous beta</p>



<a name="205494318"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205494318" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205494318">(Jul 30 2020 at 15:36)</a>:</h4>
<p>I guess that's good to discuss too -- I had a different concern too</p>



<a name="205494325"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205494325" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205494325">(Jul 30 2020 at 15:36)</a>:</h4>
<p>because it missed that train by some number of hours (which, in our world, is a near miss)</p>



<a name="205494332"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205494332" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205494332">(Jul 30 2020 at 15:36)</a>:</h4>
<p>(with the track caller stable nom)</p>



<a name="205494337"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205494337" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205494337">(Jul 30 2020 at 15:36)</a>:</h4>
<p>I see</p>



<a name="205494363"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205494363" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205494363">(Jul 30 2020 at 15:37)</a>:</h4>
<p>but <em>that</em> concern I feel like I have a viable solution for, whereas this one I don't</p>



<a name="205494364"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205494364" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205494364">(Jul 30 2020 at 15:37)</a>:</h4>
<p>I suppose this topic could/should be a retrospective on both PR's</p>



<a name="205494422"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205494422" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205494422">(Jul 30 2020 at 15:37)</a>:</h4>
<p>(for that one, the plan is to open <a class="stream" data-stream-id="241545" href="/#narrow/stream/241545-t-release">#t-release</a> streams on all stable-noms, so that we can plan to include them in artifacts)</p>



<a name="205494432"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205494432" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205494432">(Jul 30 2020 at 15:37)</a>:</h4>
<p>For PR <a href="https://github.com/rust-lang/rust/issues/73613">#73613</a>, <span class="user-mention" data-user-id="125250">@Wesley Wiser</span> had said that maybe we should, as a standard process, just review all the PR's that land in nightly 24 hours after the train leaves</p>



<a name="205494488"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205494488" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205494488">(Jul 30 2020 at 15:38)</a>:</h4>
<p>and evaluate whether they should be beta-nominated</p>



<a name="205494540"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205494540" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205494540">(Jul 30 2020 at 15:38)</a>:</h4>
<p>Hm. So I personally think it'd be easier to just beta-nominate anything that may need backporting in the week of the release, regardless of when it lands</p>



<a name="205494579"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205494579" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205494579">(Jul 30 2020 at 15:38)</a>:</h4>
<p>if it gets included by virtue of landing quickly enough, no problem, backport is trivial</p>



<a name="205494584"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205494584" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205494584">(Jul 30 2020 at 15:38)</a>:</h4>
<p>I guess that's my point: Why didn't we know that this needed backporting?</p>



<a name="205494603"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205494603" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205494603">(Jul 30 2020 at 15:39)</a>:</h4>
<p>Was it because the issue was not properly tagged?</p>



<a name="205494648"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205494648" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205494648">(Jul 30 2020 at 15:39)</a>:</h4>
<p>I note that <span class="user-mention" data-user-id="124288">@oli</span> <em>removed</em> the beta-nom here <a href="https://github.com/rust-lang/rust/pull/73613#event-3471714378">https://github.com/rust-lang/rust/pull/73613#event-3471714378</a></p>



<a name="205494660"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205494660" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205494660">(Jul 30 2020 at 15:39)</a>:</h4>
<p>I guess that's because it wasn't in that beta?</p>



<a name="205494673"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205494673" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205494673">(Jul 30 2020 at 15:39)</a>:</h4>
<p>Maybe we need beta-1.45-nom or something</p>



<a name="205494734"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205494734" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205494734">(Jul 30 2020 at 15:40)</a>:</h4>
<p>(it <em>is</em> a frequent point of confusion which beta things are targeting around release weeks)</p>



<a name="205494863"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205494863" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205494863">(Jul 30 2020 at 15:41)</a>:</h4>
<p>I don't remember why I changed this. I should comment on such actions <span aria-label="confused" class="emoji emoji-1f615" role="img" title="confused">:confused:</span></p>



<a name="205494867"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205494867" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205494867">(Jul 30 2020 at 15:41)</a>:</h4>
<p>hmm, yes at that same time <span class="user-mention" data-user-id="124288">@oli</span> also revised the tags on issue <a href="https://github.com/rust-lang/rust/issues/73609">#73609</a></p>



<a name="205494909"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205494909" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205494909">(Jul 30 2020 at 15:41)</a>:</h4>
<p><span class="user-mention" data-user-id="124288">@oli</span> I don't think this is entirely your fault: You said at least that you were trying it out in the playground</p>



<a name="205494969"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205494969" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205494969">(Jul 30 2020 at 15:42)</a>:</h4>
<p>okay so this seems like an entirely understandable error</p>



<a name="205495048"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205495048" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205495048">(Jul 30 2020 at 15:42)</a>:</h4>
<p>but is there any reasonable way to avoid it in the future?</p>



<a name="205495556"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205495556" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205495556">(Jul 30 2020 at 15:46)</a>:</h4>
<p>24 hour window feels like a partial fix at best</p>



<a name="205495586"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205495586" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205495586">(Jul 30 2020 at 15:47)</a>:</h4>
<p>For example: some way to run the beta release against <em>just</em> the regression test suite on the nightly channel</p>



<a name="205495630"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205495630" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205495630">(Jul 30 2020 at 15:47)</a>:</h4>
<p>If we had such a test suite... yes, we could probably make that happen</p>



<a name="205495632"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205495632" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205495632">(Jul 30 2020 at 15:47)</a>:</h4>
<p>where the idea is that the regression test suite will contain only things that <em>should work</em> on the beta</p>



<a name="205495675"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205495675" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205495675">(Jul 30 2020 at 15:47)</a>:</h4>
<p>right, the problem there is that we don't have proper metadata to isolate just those tests</p>



<a name="205495748"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205495748" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205495748">(Jul 30 2020 at 15:48)</a>:</h4>
<p>Maybe we should actually make sure that all regression-from-stable-to-nightly are confirmed as fixed on beta before being closed</p>



<a name="205495765"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205495765" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205495765">(Jul 30 2020 at 15:48)</a>:</h4>
<p>that's probably a more reasonable approach</p>



<a name="205495792"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205495792" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205495792">(Jul 30 2020 at 15:48)</a>:</h4>
<p>(I guess only in release week? Obviously many are just fixed on nightly)</p>



<a name="205495810"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205495810" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205495810">(Jul 30 2020 at 15:48)</a>:</h4>
<p>How many tests do we add during each release cycle?</p>



<a name="205495880"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205495880" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205495880">(Jul 30 2020 at 15:49)</a>:</h4>
<p>how much work would it be to test the current nightly test suite using the beta compiler before a stable release?</p>



<a name="205495915"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205495915" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205495915">(Jul 30 2020 at 15:49)</a>:</h4>
<p>we could, as standard operating procedure, backport any tests added for regression-stable-to-nightly to the beta channel</p>



<a name="205495997"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205495997" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205495997">(Jul 30 2020 at 15:50)</a>:</h4>
<p>I guess we expect that to <em>always</em> work, right?</p>



<a name="205496007"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205496007" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205496007">(Jul 30 2020 at 15:50)</a>:</h4>
<p>since otherwise it's a stable-to-beta regression</p>



<a name="205496017"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205496017" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205496017">(Jul 30 2020 at 15:50)</a>:</h4>
<p><span class="user-mention silent" data-user-id="216206">lcnr</span> <a href="#narrow/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613/near/205495880">said</a>:</p>
<blockquote>
<p>how much work would it be to test the current nightly test suite using the beta compiler before a stable release?</p>
</blockquote>
<p>a problem with this is that the nightly test suite will be exercising features that aren't in beta yet</p>



<a name="205496045"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205496045" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205496045">(Jul 30 2020 at 15:50)</a>:</h4>
<p>that's why I was careful up above to say that we needed to isolate just the regression tests</p>



<a name="205496071"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205496071" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205496071">(Jul 30 2020 at 15:51)</a>:</h4>
<p>yeah, but doing it once might be simple enough to check manually</p>



<a name="205496132"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205496132" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205496132">(Jul 30 2020 at 15:51)</a>:</h4>
<p>I don't know about that. It will be a pain to review all the failing tests</p>



<a name="205496133"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205496133" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205496133">(Jul 30 2020 at 15:51)</a>:</h4>
<p>I think it wouldn't be too hard to pull out any tests added and include them in backports, presuming we had a list of candidates and asked authors to split them into separate commits</p>



<a name="205496167"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205496167" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205496167">(Jul 30 2020 at 15:51)</a>:</h4>
<p>I do worry that backporting tests will be some amount of labor for a problem that is quite rare</p>



<a name="205496271"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205496271" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205496271">(Jul 30 2020 at 15:52)</a>:</h4>
<p>if they're in their own commits it is not that much work, so long as we do not go through t-compiler nomination process</p>



<a name="205496301"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205496301" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205496301">(Jul 30 2020 at 15:52)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> hmm, you know, we don't necessarily have to have them be separate commits; we can just look at <code>git diff</code> for <code>src/test</code> for all such issues tagged <code>regression-stable-to-nightly</code>, right?</p>



<a name="205496331"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205496331" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205496331">(Jul 30 2020 at 15:53)</a>:</h4>
<p>oh yeah there's no way we'd want to go through T-compiler nomination for this</p>



<a name="205496339"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205496339" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205496339">(Jul 30 2020 at 15:53)</a>:</h4>
<p>...cherry-picking diffs is a <em>lot</em> harder than just passing a hash to git cherry-pick</p>



<a name="205496378"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205496378" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205496378">(Jul 30 2020 at 15:53)</a>:</h4>
<p>I was thinking a script would do the cherry-picking of diffs</p>



<a name="205496405"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205496405" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205496405">(Jul 30 2020 at 15:53)</a>:</h4>
<p>maybe</p>



<a name="205496417"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205496417" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205496417">(Jul 30 2020 at 15:54)</a>:</h4>
<p>not sure -- seems somewhat hard</p>



<a name="205496491"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205496491" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205496491">(Jul 30 2020 at 15:54)</a>:</h4>
<p>okay yeah thinking on it more, it may be harder than I appreciate</p>



<a name="205496541"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205496541" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205496541">(Jul 30 2020 at 15:54)</a>:</h4>
<p>since its not always easy to go from a line in the diff to the issue that its PR was fixing (to find the associated label)</p>



<a name="205496571"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205496571" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205496571">(Jul 30 2020 at 15:55)</a>:</h4>
<p>and also, the tests one adds for a PR, even a regression PR, are not always regression tests</p>



<a name="205496580"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205496580" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205496580">(Jul 30 2020 at 15:55)</a>:</h4>
<p>so okay</p>



<a name="205496610"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205496610" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205496610">(Jul 30 2020 at 15:55)</a>:</h4>
<p>Lets instead try to encourage people to put such tests into their own commits</p>



<a name="205496633"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205496633" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205496633">(Jul 30 2020 at 15:55)</a>:</h4>
<p>and maybe have some keyword/tag that should be in the commit message?</p>



<a name="205496703"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205496703" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205496703">(Jul 30 2020 at 15:56)</a>:</h4>
<p>e.g. <code>backportable-test</code> or something?</p>



<a name="205496752"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205496752" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205496752">(Jul 30 2020 at 15:56)</a>:</h4>
<p>seems good</p>



<a name="205496791"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205496791" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205496791">(Jul 30 2020 at 15:56)</a>:</h4>
<p>the problem there is that you cannot change a commit message after the fact</p>



<a name="205496834"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205496834" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205496834">(Jul 30 2020 at 15:56)</a>:</h4>
<p>while we may want to add this metadata to commits that already exist, during PR review</p>



<a name="205496882"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205496882" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205496882">(Jul 30 2020 at 15:57)</a>:</h4>
<p>does github let you add metadata to commits that we could query here?</p>



<a name="205496887"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205496887" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205496887">(Jul 30 2020 at 15:57)</a>:</h4>
<p>/me goes to look</p>



<a name="205496890"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205496890" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205496890">(Jul 30 2020 at 15:57)</a>:</h4>
<p>We can open an issue per release that you post the commit hash and issue# in</p>



<a name="205496912"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205496912" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205496912">(Jul 30 2020 at 15:57)</a>:</h4>
<p>you can also do the git note thing but that seems hard</p>



<a name="205496931"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205496931" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205496931">(Jul 30 2020 at 15:57)</a>:</h4>
<p>hmm yes okay that might be good</p>



<a name="205496942"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205496942" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205496942">(Jul 30 2020 at 15:57)</a>:</h4>
<p>(the issue per release, that is)</p>



<a name="205497066"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205497066" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205497066">(Jul 30 2020 at 15:58)</a>:</h4>
<p>and, to be clear: <code>git cherry-pick</code> cannot be told to only apply a subset of the commit, namely the stuff under <code>src/test</code> in the diff?</p>



<a name="205497100"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205497100" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205497100">(Jul 30 2020 at 15:59)</a>:</h4>
<p>not to my knowledge, and regardless as you mentioned you might be adding non-regression tests too</p>



<a name="205497117"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205497117" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205497117">(Jul 30 2020 at 15:59)</a>:</h4>
<p>I think the hardest bit here is telling people to do this</p>



<a name="205497120"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205497120" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205497120">(Jul 30 2020 at 15:59)</a>:</h4>
<p>right, I'm giving up on automating this</p>



<a name="205497160"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205497160" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205497160">(Jul 30 2020 at 15:59)</a>:</h4>
<p>(I can't imagine us not missing anything with the hundreds of PRs we have per week, realistically)</p>



<a name="205497184"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205497184" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205497184">(Jul 30 2020 at 15:59)</a>:</h4>
<p>Sorry, reading the scrollback now...</p>



<a name="205497398"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205497398" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205497398">(Jul 30 2020 at 16:01)</a>:</h4>
<p>Is there a set schedule for when <code>beta</code> gets branched?</p>



<a name="205497438"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205497438" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205497438">(Jul 30 2020 at 16:01)</a>:</h4>
<p>sort of</p>



<a name="205497466"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205497466" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205497466">(Jul 30 2020 at 16:01)</a>:</h4>
<p><a href="https://forge.rust-lang.org/release/process.html#promote-master-to-beta-t-2-days-tuesday">https://forge.rust-lang.org/release/process.html#promote-master-to-beta-t-2-days-tuesday</a></p>



<a name="205497526"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205497526" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205497526">(Jul 30 2020 at 16:02)</a>:</h4>
<p>but that can happen basically whenever on that Tuesday, and if something is wonky in a given week we might delay</p>



<a name="205497543"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205497543" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205497543">(Jul 30 2020 at 16:02)</a>:</h4>
<p>(e.g., if their are toolstate regressions)</p>



<a name="205497578"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205497578" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205497578">(Jul 30 2020 at 16:02)</a>:</h4>
<p>Ok, gotcha</p>



<a name="205497593"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205497593" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205497593">(Jul 30 2020 at 16:02)</a>:</h4>
<p>I guess the official workflow for this is as follows: <a href="https://jasonrudolph.com/blog/2009/02/25/git-tip-how-to-merge-specific-files-from-another-branch/">https://jasonrudolph.com/blog/2009/02/25/git-tip-how-to-merge-specific-files-from-another-branch/</a></p>



<a name="205497625"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205497625" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205497625">(Jul 30 2020 at 16:03)</a>:</h4>
<p>namely, <code>git checkout pr-branch src/test</code></p>



<a name="205497722"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205497722" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205497722">(Jul 30 2020 at 16:03)</a>:</h4>
<p>I think <span class="user-mention" data-user-id="116122">@simulacrum</span>'s suggestion of "over tagging" to make sure we don't miss beta backports seems good to me. Obviously that's going to be a manual process and we'd only want to do it right around release week, but I think it would still be a step up from what we're doing now.</p>



<a name="205497878"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205497878" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205497878">(Jul 30 2020 at 16:04)</a>:</h4>
<p>sorry, "over tagging" ?</p>



<a name="205497887"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205497887" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205497887">(Jul 30 2020 at 16:04)</a>:</h4>
<p>Would probably be worth adding an agenda item the week before the release to remind people to tag PRs.</p>



<a name="205497942"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205497942" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205497942">(Jul 30 2020 at 16:05)</a>:</h4>
<p><a href="#narrow/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613/near/205494540">https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613/near/205494540</a></p>



<a name="205498027"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498027" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498027">(Jul 30 2020 at 16:05)</a>:</h4>
<p>but would that have resolved this issue?</p>



<a name="205498126"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498126" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498126">(Jul 30 2020 at 16:06)</a>:</h4>
<p>there was a lack of clarity about whether a backport was needed</p>



<a name="205498153"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498153" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498153">(Jul 30 2020 at 16:06)</a>:</h4>
<p>Hmm perhaps not</p>



<a name="205498155"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498155" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498155">(Jul 30 2020 at 16:06)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/issues/73609#issuecomment-647685084">https://github.com/rust-lang/rust/issues/73609#issuecomment-647685084</a></p>



<a name="205498177"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498177" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498177">(Jul 30 2020 at 16:06)</a>:</h4>
<p>Looks like many of us were confused by which versions were affected.</p>



<a name="205498242"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498242" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498242">(Jul 30 2020 at 16:07)</a>:</h4>
<p>I guess bisection is the right thing, sort of, but more of "this is broken on X Y Z versions"</p>



<a name="205498262"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498262" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498262">(Jul 30 2020 at 16:07)</a>:</h4>
<p>another thought I just had</p>



<a name="205498310"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498310" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498310">(Jul 30 2020 at 16:08)</a>:</h4>
<p>i.e., more automated than people manually trying to check and getting things misclicked and such</p>



<a name="205498315"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498315" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498315">(Jul 30 2020 at 16:08)</a>:</h4>
<p>As soon as a <code>regression-stable-to-nightly</code> bug is <em>filed</em></p>



<a name="205498329"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498329" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498329">(Jul 30 2020 at 16:08)</a>:</h4>
<p>we immediately make a test and backport it to beta</p>



<a name="205498399"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498399" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498399">(Jul 30 2020 at 16:09)</a>:</h4>
<p>high-work in some sense (branch + write a test and commit + PR + review)</p>



<a name="205498401"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498401" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498401">(Jul 30 2020 at 16:09)</a>:</h4>
<p>though that might be attacking a different problem</p>



<a name="205498416"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498416" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498416">(Jul 30 2020 at 16:09)</a>:</h4>
<p>but it... could be the right idea</p>



<a name="205498422"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498422" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498422">(Jul 30 2020 at 16:09)</a>:</h4>
<p>often we don't have a MCVE until the fix is found</p>



<a name="205498438"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498438" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498438">(Jul 30 2020 at 16:09)</a>:</h4>
<p>its true, our infrastructure doesn't make this as trivial as I make it sound</p>



<a name="205498540"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498540" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498540">(Jul 30 2020 at 16:10)</a>:</h4>
<p>perhaps because we should have a lower bar for adding tests? but then again, our test suite is a source of CI slowness, right?</p>



<a name="205498585"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498585" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498585">(Jul 30 2020 at 16:10)</a>:</h4>
<p>I'm going to stop brainstorming about this and go work on other stuff for a while</p>



<a name="205498600"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498600" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498600">(Jul 30 2020 at 16:10)</a>:</h4>
<p>Well, I think we would generally want a test anyway so backporting it shouldn't cause a lot of bloat in the test suite.</p>



<a name="205498602"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498602" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498602">(Jul 30 2020 at 16:10)</a>:</h4>
<p>well that doesn't eliminate ~any of those steps, right?</p>



<a name="205498622"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498622" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498622">(Jul 30 2020 at 16:11)</a>:</h4>
<p>it's just "small patches are always greatly outweighed by the metawork"</p>



<a name="205498659"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498659" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498659">(Jul 30 2020 at 16:11)</a>:</h4>
<p>(also why we e.g. don't tend to allow big PRs fixing typos)</p>



<a name="205498661"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498661" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498661">(Jul 30 2020 at 16:11)</a>:</h4>
<p>Imagine a one click way to say "Take this playground link, turn it into a test and post a PR for it."</p>



<a name="205498721"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498721" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498721">(Jul 30 2020 at 16:12)</a>:</h4>
<p>the review time is still killer though</p>



<a name="205498734"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498734" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498734">(Jul 30 2020 at 16:12)</a>:</h4>
<p>we could just ... not review the test</p>



<a name="205498738"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498738" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498738">(Jul 30 2020 at 16:12)</a>:</h4>
<p>Yes</p>



<a name="205498762"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498762" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498762">(Jul 30 2020 at 16:12)</a>:</h4>
<p>I guess that was what I was thinking of when I said "a lower bar "</p>



<a name="205498775"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498775" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498775">(Jul 30 2020 at 16:12)</a>:</h4>
<p>the risk there is that the test doesn't actually test it</p>



<a name="205498788"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498788" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498788">(Jul 30 2020 at 16:12)</a>:</h4>
<p>unreviewed is a <em>very</em> low bar. :)</p>



<a name="205498792"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498792" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498792">(Jul 30 2020 at 16:12)</a>:</h4>
<p>but that seems "fine"</p>



<a name="205498833"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498833" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498833">(Jul 30 2020 at 16:12)</a>:</h4>
<p>so I think the ask is probably that automation</p>



<a name="205498843"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498843" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498843">(Jul 30 2020 at 16:12)</a>:</h4>
<p>we have that already to some extent with glacier</p>



<a name="205498870"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498870" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498870">(Jul 30 2020 at 16:13)</a>:</h4>
<p>(well, we've been fixing bugs in it for what feels like this whole year)</p>



<a name="205498878"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498878" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498878">(Jul 30 2020 at 16:13)</a>:</h4>
<p>There's also some non-obvious things with our testing infra. Just because it fails on the playgroud doesn't mean we can turn that into a test exactly. You might need to tweak things for or exclude various targets (32 bit or platforms some such).</p>



<a name="205498879"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498879" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498879">(Jul 30 2020 at 16:13)</a>:</h4>
<p>right. <code>@rustbot make-beta-test-from-playground &lt;link&gt;</code></p>



<a name="205498971"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498971" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498971">(Jul 30 2020 at 16:13)</a>:</h4>
<p><span class="user-mention" data-user-id="125250">@Wesley Wiser</span> sure. But presumably if a PR passes the CI, then its okay?</p>



<a name="205498977"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498977" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498977">(Jul 30 2020 at 16:13)</a>:</h4>
<p><span class="user-mention" data-user-id="125250">@Wesley Wiser</span> yeah, though some of that can be resolved in PR targeting beta -- i.e., beta rollup</p>



<a name="205498988"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205498988" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205498988">(Jul 30 2020 at 16:14)</a>:</h4>
<p>Also if you're "Building" on the playground, that's now what our test infra does.</p>



<a name="205499058"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205499058" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205499058">(Jul 30 2020 at 16:14)</a>:</h4>
<p>we just need to be more cautious about r+'ing that immediately</p>



<a name="205499064"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205499064" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205499064">(Jul 30 2020 at 16:14)</a>:</h4>
<p>I found a test we added last week that passed only because <code>main()</code> didn't call anything which generated the ICE.</p>



<a name="205499071"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205499071" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205499071">(Jul 30 2020 at 16:14)</a>:</h4>
<p><span class="user-mention silent" data-user-id="125250">Wesley Wiser</span> <a href="#narrow/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613/near/205498988">said</a>:</p>
<blockquote>
<p>Also if you're "Building" on the playground, that's now what our test infra does.</p>
</blockquote>
<p>I didn't understand this</p>



<a name="205499112"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205499112" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205499112">(Jul 30 2020 at 16:15)</a>:</h4>
<p>When you "Build" on the playground you get <code>--crate-type lib</code> but our test suite does <code>--crate-type bin</code></p>



<a name="205499130"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205499130" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205499130">(Jul 30 2020 at 16:15)</a>:</h4>
<p>the reference to the playground was just meant to be a place to get the source code</p>



<a name="205499143"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205499143" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205499143">(Jul 30 2020 at 16:15)</a>:</h4>
<p>Gotcha</p>



<a name="205499154"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205499154" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205499154">(Jul 30 2020 at 16:15)</a>:</h4>
<p>I see, yes, the playground's context is different from the CI's</p>



<a name="205499190"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205499190" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205499190">(Jul 30 2020 at 16:15)</a>:</h4>
<p>I just figure its easier to reference playground links and extract source from them, versus e.g. scraping github comments</p>



<a name="205499193"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205499193" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205499193">(Jul 30 2020 at 16:15)</a>:</h4>
<p>FWIW, I wouldn't have an issue doing this manually for <code>regression-stable-to-*</code> issues.</p>



<a name="205499277"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205499277" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205499277">(Jul 30 2020 at 16:16)</a>:</h4>
<p><span class="user-mention silent" data-user-id="125250">Wesley Wiser</span> <a href="#narrow/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613/near/205499193">said</a>:</p>
<blockquote>
<p>FWIW, I wouldn't have an issue doing this manually for <code>regression-stable-to-*</code> issues.</p>
</blockquote>
<p>as in, you don't think its worth investing in infra to automate it?</p>



<a name="205499329"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205499329" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205499329">(Jul 30 2020 at 16:16)</a>:</h4>
<p>I think that would be great but I don't want the lack of automation to stop us from finding a fix to the process issue.</p>



<a name="205499350"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205499350" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205499350">(Jul 30 2020 at 16:17)</a>:</h4>
<p>I agree with that</p>



<a name="205499406"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205499406" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205499406">(Jul 30 2020 at 16:17)</a>:</h4>
<p>Another option would be to do an "ice breaker" like team and ping people to crowd source it</p>



<a name="205499430"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205499430" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205499430">(Jul 30 2020 at 16:17)</a>:</h4>
<p>It's an easy contribution once there's a fix with a test case.</p>



<a name="205499431"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205499431" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205499431">(Jul 30 2020 at 16:17)</a>:</h4>
<p>(and I'm still not sure we've identified a fix to the process issue. In part because we don't know 100% <em>why</em> the process failed here; we know this was nominated and unnominated, and we aren't certain why.)</p>



<a name="205499517"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205499517" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205499517">(Jul 30 2020 at 16:18)</a>:</h4>
<p>I think the un-nomination was a result of my comment here <a href="https://github.com/rust-lang/rust/issues/73609#issuecomment-647685084">https://github.com/rust-lang/rust/issues/73609#issuecomment-647685084</a></p>



<a name="205499537"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205499537" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205499537">(Jul 30 2020 at 16:18)</a>:</h4>
<p>right, but your logic seemed reasonable, no?</p>



<a name="205499545"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205499545" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205499545">(Jul 30 2020 at 16:18)</a>:</h4>
<p>Yeah</p>



<a name="205499600"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205499600" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205499600">(Jul 30 2020 at 16:19)</a>:</h4>
<p>So it seems <span class="user-mention" data-user-id="124288">@oli</span> was right to begin with but we don't know how</p>



<a name="205499618"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205499618" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205499618">(Jul 30 2020 at 16:19)</a>:</h4>
<p>Was it something where the nightly-t-beta lift happened right on June 21st or something?</p>



<a name="205499663"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205499663" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205499663">(Jul 30 2020 at 16:19)</a>:</h4>
<p>That was a Sunday which doesn't sound right per the above timeline</p>



<a name="205499933"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205499933" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205499933">(Jul 30 2020 at 16:21)</a>:</h4>
<p>Is there anyway to find out when the beta branch was updated?</p>



<a name="205499955"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205499955" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205499955">(Jul 30 2020 at 16:21)</a>:</h4>
<p>That seems like a critical piece of info we don't have currently</p>



<a name="205499960"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205499960" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205499960">(Jul 30 2020 at 16:21)</a>:</h4>
<p>well no but you <em>can</em> tell when it branched</p>



<a name="205500009"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205500009" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205500009">(Jul 30 2020 at 16:22)</a>:</h4>
<p>which release are we talking about? 1.45?</p>



<a name="205500045"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205500045" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205500045">(Jul 30 2020 at 16:22)</a>:</h4>
<p>Yeah</p>



<a name="205500066"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205500066" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205500066">(Jul 30 2020 at 16:22)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/commit/eeaf497b2a6bc065874e3d3367b1f3023c5bb3d3">eeaf497b2a6bc065874e3d3367b1f3023c5bb3d3</a> is I believe when 1.45.0 and master diverged</p>



<a name="205500185"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205500185" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205500185">(Jul 30 2020 at 16:23)</a>:</h4>
<p>found via git merge-base --fork-point origin/master 1.45.0</p>



<a name="205500298"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205500298" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205500298">(Jul 30 2020 at 16:24)</a>:</h4>
<p>yeah manually checking that seems right</p>



<a name="205500499"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205500499" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205500499">(Jul 30 2020 at 16:26)</a>:</h4>
<p>I'm very confused then</p>



<a name="205500548"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205500548" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205500548">(Jul 30 2020 at 16:26)</a>:</h4>
<p>That commit is from June 2 but the broken commit landed on June 21</p>



<a name="205500587"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205500587" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205500587">(Jul 30 2020 at 16:26)</a>:</h4>
<p>I'm trying to figure out if we just stable-approved something that isn't actually a bug on stable...</p>



<a name="205500627"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205500627" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205500627">(Jul 30 2020 at 16:27)</a>:</h4>
<p>We got a bug report about stable though...</p>



<a name="205500690"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205500690" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205500690">(Jul 30 2020 at 16:27)</a>:</h4>
<p>maybe we backported the thing that broke it?</p>



<a name="205500907"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205500907" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205500907">(Jul 30 2020 at 16:29)</a>:</h4>
<p>wow I wasn't aware of the comment thread on issue <a href="https://github.com/rust-lang/rust/issues/74739">#74739</a></p>



<a name="205501061"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205501061" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205501061">(Jul 30 2020 at 16:30)</a>:</h4>
<p>yeah :/</p>



<a name="205501080"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205501080" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205501080">(Jul 30 2020 at 16:30)</a>:</h4>
<p>I can't even find the offending commit on <code>stable</code></p>



<a name="205501120"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205501120" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205501120">(Jul 30 2020 at 16:31)</a>:</h4>
<p>Yeah, it was the on the front page of /r/rust</p>



<a name="205501366"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205501366" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205501366">(Jul 30 2020 at 16:33)</a>:</h4>
<p>Huh</p>



<a name="205501398"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205501398" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205501398">(Jul 30 2020 at 16:33)</a>:</h4>
<p>I should stop clicking through GH's commit log and just use git</p>



<a name="205501400"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205501400" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205501400">(Jul 30 2020 at 16:33)</a>:</h4>
<p>Okay I'm re-invested now in figuring this out. :)</p>



<a name="205501489"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205501489" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205501489">(Jul 30 2020 at 16:34)</a>:</h4>
<p>Oh wow</p>



<a name="205501494"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205501494" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205501494">(Jul 30 2020 at 16:34)</a>:</h4>
<p>So <a href="https://github.com/rust-lang/rust/commit/c06876c90437c7eecd1dc246d3515d6211397f16">c06876c90437c7eecd1dc246d3515d6211397f16</a> and <a href="https://github.com/rust-lang/rust/commit/2f49d554ff1afd1633a01d6b84192ad0147d9097">2f49d554ff1afd1633a01d6b84192ad0147d9097</a> are <em>not</em> in 1.45 it seems?</p>



<a name="205501503"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205501503" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205501503">(Jul 30 2020 at 16:34)</a>:</h4>
<p><code>stable</code> is the right branch for <code>1.45</code> right?</p>



<a name="205501518"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205501518" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205501518">(Jul 30 2020 at 16:34)</a>:</h4>
<p>for 1.45.1</p>



<a name="205501521"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205501521" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205501521">(Jul 30 2020 at 16:34)</a>:</h4>
<p>but we didn't revert them..</p>



<a name="205501538"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205501538" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205501538">(Jul 30 2020 at 16:34)</a>:</h4>
<p>We wouldn't have removed those commits and <code>push -f </code> or something right?</p>



<a name="205501547"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205501547" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205501547">(Jul 30 2020 at 16:35)</a>:</h4>
<p>no</p>



<a name="205501558"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205501558" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205501558">(Jul 30 2020 at 16:35)</a>:</h4>
<p>1.45.0 is the stable tag</p>



<a name="205501562"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205501562" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205501562">(Jul 30 2020 at 16:35)</a>:</h4>
<p>So yeah, they're not there</p>



<a name="205501568"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205501568" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205501568">(Jul 30 2020 at 16:35)</a>:</h4>
<p>Oh true</p>



<a name="205501582"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205501582" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205501582">(Jul 30 2020 at 16:35)</a>:</h4>
<p>but they're not there</p>



<a name="205501590"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205501590" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205501590">(Jul 30 2020 at 16:35)</a>:</h4>
<p>wth</p>



<a name="205501595"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205501595" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205501595">(Jul 30 2020 at 16:35)</a>:</h4>
<p>so either we misdiagnosed the cause and the fix just happens to work or something... is weird</p>



<a name="205501629"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205501629" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205501629">(Jul 30 2020 at 16:36)</a>:</h4>
<p>I mean, it's possible there was a different similar bug that this also fixed</p>



<a name="205501693"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205501693" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205501693">(Jul 30 2020 at 16:36)</a>:</h4>
<p>But that would be a totally unknown bug</p>



<a name="205501735"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205501735" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205501735">(Jul 30 2020 at 16:36)</a>:</h4>
<p>And since RalfJ found this bug literally hours after the bad commit landed, it seems kind of unlikely.</p>



<a name="205501808"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205501808" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205501808">(Jul 30 2020 at 16:37)</a>:</h4>
<p>hm okay now I want to re-confirm that we did fix this in 1.45.1 (yet to be released)</p>



<a name="205501846"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205501846" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205501846">(Jul 30 2020 at 16:37)</a>:</h4>
<p>You should double check me but I did test the reported issue when I made the patch.</p>



<a name="205501909"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205501909" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205501909">(Jul 30 2020 at 16:38)</a>:</h4>
<p>yeah ... I feel like we even included tests?</p>



<a name="205501934"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205501934" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205501934">(Jul 30 2020 at 16:38)</a>:</h4>
<p>oli had added some tests for the original issue</p>



<a name="205501955"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205501955" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205501955">(Jul 30 2020 at 16:38)</a>:</h4>
<p>I have a TODO to add a test with the specific test case from the stable bug report.</p>



<a name="205502059"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205502059" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205502059">(Jul 30 2020 at 16:39)</a>:</h4>
<p>okay the patch <em>is</em> fixed in 1.45.1</p>



<a name="205502068"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205502068" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205502068">(Jul 30 2020 at 16:39)</a>:</h4>
<p>er, bug</p>



<a name="205502220"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205502220" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205502220">(Jul 30 2020 at 16:40)</a>:</h4>
<p>but we don't yet know what caused it in 1.45.0 right?</p>



<a name="205502228"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205502228" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205502228">(Jul 30 2020 at 16:40)</a>:</h4>
<p>since the bad commits don't seem to be in it</p>



<a name="205502234"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205502234" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205502234">(Jul 30 2020 at 16:40)</a>:</h4>
<p>Right</p>



<a name="205502256"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205502256" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205502256">(Jul 30 2020 at 16:41)</a>:</h4>
<p>I guess we could bisect</p>



<a name="205502277"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205502277" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205502277">(Jul 30 2020 at 16:41)</a>:</h4>
<p>yeah i'm going to try to do that (bisect) on my machine now</p>



<a name="205502839"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205502839" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205502839">(Jul 30 2020 at 16:46)</a>:</h4>
<p>hm so the issue repro bisects to <a href="https://github.com/rust-lang/rust/commit/3fe4dd2dda2826643c4ce4ee7307707a90e08d25">https://github.com/rust-lang/rust/commit/3fe4dd2dda2826643c4ce4ee7307707a90e08d25</a> for me</p>



<a name="205502847"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205502847" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205502847">(Jul 30 2020 at 16:46)</a>:</h4>
<p>1.44 definitely <strong>does not</strong> have the issue and 1.45 definitely <strong>does</strong>. I just checked.</p>



<a name="205503071"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205503071" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205503071">(Jul 30 2020 at 16:48)</a>:</h4>
<p>I am not sure if that's because 3fe4dd enabled some code (that would've been broken previously) or not, though</p>



<a name="205503207"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205503207" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205503207">(Jul 30 2020 at 16:49)</a>:</h4>
<p>and that commit, 3fe4dd, does appear to be in 1.45 and not in 1.44</p>



<a name="205506057"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205506057" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205506057">(Jul 30 2020 at 17:17)</a>:</h4>
<p>Perhaps oli managed to trigger the existing issue on the (then) beta branch and we didn't realize that meant there was an existing issue.</p>



<a name="205506456"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205506456" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205506456">(Jul 30 2020 at 17:21)</a>:</h4>
<p>perhaps, yeah</p>



<a name="205520190"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205520190" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205520190">(Jul 30 2020 at 19:12)</a>:</h4>
<p>okay, so in the end, I think we can conclude that <a href="https://github.com/rust-lang/rust/issues/74739">#74739</a> was in fact <strong>not</strong> a duplicate of <a href="https://github.com/rust-lang/rust/issues/73609">#73609</a>, right?</p>



<a name="205520213"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205520213" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205520213">(Jul 30 2020 at 19:12)</a>:</h4>
<p>because that claim was, AFAICT, a big part of what led to confusion today</p>



<a name="205525120"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205525120" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205525120">(Jul 30 2020 at 19:58)</a>:</h4>
<p>maybe? I'm not sure :/</p>



<a name="205526027"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205526027" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205526027">(Jul 30 2020 at 20:06)</a>:</h4>
<p>hey guys, sorry, I was busy most of the day and missed all this discussion</p>



<a name="205526103"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205526103" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205526103">(Jul 30 2020 at 20:06)</a>:</h4>
<p>going to read the thread but skimming it a bit I'm not sure if we did conclude something about what should we do to avoid such situations</p>



<a name="205526142"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205526142" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205526142">(Jul 30 2020 at 20:07)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> kind of unrelated but a thing I was mentioning during the meeting is <a href="https://calendar.google.com/calendar/embed?src=mozilla.com_ts4qudb88i0tbjef8rche4a6v4%40group.calendar.google.com&amp;ctz=America%2FMontevideo">https://calendar.google.com/calendar/embed?src=mozilla.com_ts4qudb88i0tbjef8rche4a6v4%40group.calendar.google.com&amp;ctz=America%2FMontevideo</a></p>



<a name="205526162"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205526162" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205526162">(Jul 30 2020 at 20:07)</a>:</h4>
<p>this is the calendar I'm using for Rust releases</p>



<a name="205526205"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205526205" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205526205">(Jul 30 2020 at 20:07)</a>:</h4>
<p>unsure from where did I got but is something that I've been following since ages and I thought it was something official</p>



<a name="205526233"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205526233" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205526233">(Jul 30 2020 at 20:07)</a>:</h4>
<p>yeah I know nothing about it, seems like some mozilla thing</p>



<a name="205526235"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205526235" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205526235">(Jul 30 2020 at 20:07)</a>:</h4>
<p>it would be nice to know from an official source when releases happen</p>



<a name="205526334"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205526334" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205526334">(Jul 30 2020 at 20:08)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613/near/205526233">said</a>:</p>
<blockquote>
<p>yeah I know nothing about it, seems like some mozilla thing</p>
</blockquote>
<p>would be reasonable to create an official one? or how should I know that a release happens ahead of time?</p>



<a name="205526357"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205526357" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205526357">(Jul 30 2020 at 20:08)</a>:</h4>
<p>So there are two possible conclusions I can draw after this retrospective</p>



<a name="205526432"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205526432" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205526432">(Jul 30 2020 at 20:09)</a>:</h4>
<p>Let's discuss release scheduling elsewhere</p>



<a name="205526442"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205526442" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205526442">(Jul 30 2020 at 20:09)</a>:</h4>
<ol>
<li>These two issues were not duplicates. So, I do not assign anyone blame in terms of "why wasn't this fix backported"; it wasn't like we overlooked a known bug</li>
</ol>



<a name="205526447"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205526447" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205526447">(Jul 30 2020 at 20:09)</a>:</h4>
<p>however</p>



<a name="205526496"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205526496" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205526496">(Jul 30 2020 at 20:09)</a>:</h4>
<p>if you read the comment thread for PR <a href="https://github.com/rust-lang/rust/issues/73613">#73613</a></p>



<a name="205526582"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205526582" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205526582">(Jul 30 2020 at 20:10)</a>:</h4>
<p>it seems clear that there <em>was</em> a big gaping hole in the const propagator</p>



<a name="205526633"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205526633" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205526633">(Jul 30 2020 at 20:10)</a>:</h4>
<p>at least, <span class="user-mention" data-user-id="120791">@RalfJ</span> expressed concern about how the bug being fixed <a href="https://github.com/rust-lang/rust/issues/73613">#73613</a> managed to get in there</p>



<a name="205570660"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205570660" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205570660">(Jul 31 2020 at 08:55)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613/near/205494332">said</a>:</p>
<blockquote>
<p>(with the track caller stable nom)</p>
</blockquote>
<p>do you have a link for that? (the thread ended being all about the constprop problem, but still I wonder what the other one even is about -- nothing here seems to link to a PR/issue)</p>



<a name="205570751"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205570751" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205570751">(Jul 31 2020 at 08:56)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116083">pnkfelix</span> <a href="#narrow/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613/near/205526582">said</a>:</p>
<blockquote>
<p>it seems clear that there <em>was</em> a big gaping hole in the const propagator</p>
</blockquote>
<p>yes. and we thought the hole was opened by <a href="https://github.com/rust-lang/rust/issues/71911">#71911</a> but it seems actually the hole was present already since <a href="https://github.com/rust-lang/rust/issues/71953">#71953</a> (higher number but landed earlier)?</p>



<a name="205570816"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205570816" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205570816">(Jul 31 2020 at 08:57)</a>:</h4>
<p><span class="user-mention" data-user-id="124288">@oli</span> described the latter as being "moderately scared" by the change^^</p>



<a name="205570868"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205570868" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205570868">(Jul 31 2020 at 08:58)</a>:</h4>
<p>uh, okay, something is odd -- the diff view at <a href="https://github.com/rust-lang/rust/pull/71911/files">https://github.com/rust-lang/rust/pull/71911/files</a> includes the diff of <a href="https://github.com/rust-lang/rust/pull/71953/files">https://github.com/rust-lang/rust/pull/71953/files</a>?</p>



<a name="205570915"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205570915" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205570915">(Jul 31 2020 at 08:59)</a>:</h4>
<p>or parts of it at least:</p>
<ul>
<li><a href="https://github.com/rust-lang/rust/pull/71911/files#diff-9e103702275cbef342c2decd3395bf3bL854">https://github.com/rust-lang/rust/pull/71911/files#diff-9e103702275cbef342c2decd3395bf3bL854</a></li>
<li><a href="https://github.com/rust-lang/rust/pull/71953/files#diff-9e103702275cbef342c2decd3395bf3bL828">https://github.com/rust-lang/rust/pull/71953/files#diff-9e103702275cbef342c2decd3395bf3bL828</a></li>
</ul>



<a name="205571041"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205571041" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205571041">(Jul 31 2020 at 09:01)</a>:</h4>
<p>ah no it just looks very similar (to someone not at all familiar with that code)</p>



<a name="205586657"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205586657" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205586657">(Jul 31 2020 at 12:54)</a>:</h4>
<p><span class="user-mention" data-user-id="120791">@RalfJ</span> I was referring to <a href="https://github.com/rust-lang/rust/issues/74764">https://github.com/rust-lang/rust/issues/74764</a> with the track caller discussions</p>



<a name="205605570"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205605570" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> yodal <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205605570">(Jul 31 2020 at 15:34)</a>:</h4>
<p>I'm not sure if this is still relevant, but very early in this discussion it was mentioned that there is a lot of confusion as to which beta things are targeting around release weeks. Could this be solved by either raging which beta the thing is meant for or even just mentioning in a comment on the issue/PR which beta something related to (maybe at the same point as when the beta-relevant tag is added)?</p>



<a name="205611813"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/205611813" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#205611813">(Jul 31 2020 at 16:30)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613/near/205586657">said</a>:</p>
<blockquote>
<p><span class="user-mention silent" data-user-id="120791">RalfJ</span> I was referring to <a href="https://github.com/rust-lang/rust/issues/74764">https://github.com/rust-lang/rust/issues/74764</a> with the track caller discussions</p>
</blockquote>
<p>thanks! I added a corresponding test to Miri, just to be sure.</p>



<a name="206679829"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/206679829" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#206679829">(Aug 12 2020 at 10:44)</a>:</h4>
<p>is there any reason <a href="https://github.com/rust-lang/rust/issues/74739">https://github.com/rust-lang/rust/issues/74739</a> is still open? should we add this as a testcase to master?</p>



<a name="206680272"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/retrospective%20on%20backport%20nomination%20for%20PR%20%2373613/near/206680272" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/retrospective.20on.20backport.20nomination.20for.20PR.20.2373613.html#206680272">(Aug 12 2020 at 10:51)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/pull/75449">https://github.com/rust-lang/rust/pull/75449</a></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>